-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing "Confusing use of '!'" warning #65
base: master
Are you sure you want to change the base?
Conversation
see [Incorrect "Confusing use of '!'" warning #780](here jshint/jshint#780)
see [Incorrect "Confusing use of '!'" warning #780](here jshint/jshint#780)
|
@eligrey My code including polyfills come through travis-ci then pass jshint. So you know what I mean. You can offer another name for workaround variables. They are obviously for avoiding surpressing jshint comments. |
I don't do usually workarounds for bugs in third party tools and libraries that don't affect functionality. It's up to the third party to fix their issue. This project now has new maintainers though so if they feel like this is necessary they may merge your PR. |
That's right, and you aren't developing in vacuum, just for art. |
@englishextra I would understand your concern if it impacted functionality, but it does not. JSHint being broken (has been for years for many types of expressions, I don't really use it anymore) doesn't mean the code will stop working or produce warnings to the end-user. |
@eligrey No problem It all ends up that I have to relint every polyfill I use, and add .fixed suffix to the filename. I'm not happy with jshint and their stubbornness, likewise I'm not happy with xo as well. So, it's up to new collaborators to merge that. Thanks. |
see [Incorrect "Confusing use of '!'" warning #780](here jshint/jshint#780)