Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing "Confusing use of '!'" warning #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing "Confusing use of '!'" warning #65

wants to merge 2 commits into from

Conversation

englishextra
Copy link

see [Incorrect "Confusing use of '!'" warning #780](here jshint/jshint#780)

see [Incorrect "Confusing use of '!'" warning #780](here jshint/jshint#780)
see [Incorrect "Confusing use of '!'" warning #780](here jshint/jshint#780)
@eligrey
Copy link
Owner

eligrey commented May 4, 2017

_ntoken and _nforce look a lot more confusing to me. Are people simply not allowed to use the negation operator now? _ntoken doesn't even describe what is represents. If I had to name a variable, I would name it token_not_found.

@englishextra
Copy link
Author

englishextra commented May 4, 2017

@eligrey My code including polyfills come through travis-ci then pass jshint. So you know what I mean. You can offer another name for workaround variables. They are obviously for avoiding surpressing jshint comments.

@eligrey
Copy link
Owner

eligrey commented May 4, 2017

I don't do usually workarounds for bugs in third party tools and libraries that don't affect functionality. It's up to the third party to fix their issue.

This project now has new maintainers though so if they feel like this is necessary they may merge your PR.

@englishextra
Copy link
Author

englishextra commented May 4, 2017

@eligrey

t's up to the third party to fix their issue.

That's right, and you aren't developing in vacuum, just for art.
Beck's aware of that issue already.

@eligrey
Copy link
Owner

eligrey commented May 4, 2017

@englishextra I would understand your concern if it impacted functionality, but it does not. JSHint being broken (has been for years for many types of expressions, I don't really use it anymore) doesn't mean the code will stop working or produce warnings to the end-user.

@englishextra
Copy link
Author

@eligrey No problem

It all ends up that I have to relint every polyfill I use, and add .fixed suffix to the filename. I'm not happy with jshint and their stubbornness, likewise I'm not happy with xo as well.

So, it's up to new collaborators to merge that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants